Repository navigation
fix pylock.toml export dropping wheels when the sdist sorts between wheels - #379
Merged
radoering merged 1 commit intoNov 21, 2026
Conversation
radoering
force-pushed
the
fix-pylock-sdist-between-wheels
branch
from
November 21, 2026 12:42
16dd63d to
5688c24
Compare
|
radoering
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request Check List
Resolves: #378
Summary
The pylock.toml export split
package.filesinto sdists and wheels withitertools.groupby.groupbyonly groups consecutive items, and the lock file sorts files by file name. When the sdist file name sorts between wheel file names, the second"wheel"group replaced the first one, so wheels were missing from the export.Real example:
ruamel.yaml.clib0.2.14 has 54ruamel.yaml.clib-*wheels, thenruamel.yaml.clib-0.2.14.tar.gz, then 2ruamel_yaml_clib-*wheels. The export listed only the last 2 wheels.This change filters
package.filesby kind instead of grouping consecutive items. The order of files within each kind is unchanged.Testing
test_export_pypi_dependencies_sdist_sorted_between_wheelsfails on main (the first wheel is missing) and passes with this change.pytest tests: 179 passed.ruff check,ruff format --checkandmypy srcare clean.No documentation change is needed because this fixes the output to match the documented behavior.